Make websafe bundle avoid core dependency - #362
Open
seveibar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@tscircuit/core→graphics-debug/pretty) that injects a TTY shim into the generateddist/browserbundle, breaking the intent of the websafe entrypoint.Description
normalizePinLabelsimplementation atlib/utils/normalize-pin-labels.tsand replaced the websafe import to use it instead of@tscircuit/core.lib/convert-easyeda-json-to-tscircuit-soup-json.tsto import the local helper and re-exported it from the package entry (lib/index.ts).tests/websafe/browser-bundle-websafe.test.tsthat runs the browser build and asserts the bundle does not contain known non-websafe artifacts (TTY shim,pretty,graphics-debug).Testing
bun test tests/normalize-pin-labels.test.tsand all tests passed.bun test tests/websafe/browser-bundle-websafe.test.tswhich builds the browser bundle and the guard passed (no TTY/pretty/graphics-debugpatterns found).bun test tests/fetch-tests/c2040.test.tswhich passed.bunx tsc --noEmit,bun run build, andbun run format, all of which completed successfully.Codex Task