Import EasyEDA courtyard (layer 12) as pcb_courtyard_outline and update snapshots - #349
Open
seveibar wants to merge 1 commit into
Open
Import EasyEDA courtyard (layer 12) as pcb_courtyard_outline and update snapshots#349seveibar wants to merge 1 commit into
seveibar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
TRACKandARCshapes on layer12topcb_courtyard_outlineelements by addinghandleCourtyardPathandhandleCourtyardArcand importingpcb_courtyard_outlinefromcircuit-jsoninlib/convert-easyeda-json-to-tscircuit-soup-json.ts.pcb_courtyard_outlineelements when computingpcb_componentbounds so component width/height reflect courtyard geometry.tests/convert-to-soup-tests/c14877-courtyard.test.tsand its SVG snapshot to verify courtyard import forC14877.Testing
BUN_UPDATE_SNAPSHOTS=1 bun test tests/convert-to-soup-tests/c14877-courtyard.test.ts, which passed and wrote the updated SVG snapshot.bun test tests/convert-to-ts/C14877.test.ts, which passed.bunx tsc --noEmit, which succeeded.bun run format, which succeeded.BUN_UPDATE_SNAPSHOTS=1 bun test tests/convert-to-tspreviously surfaced unrelated timeouts in other tests (C165948,C472489) that are not caused by this change.Codex Task