Skip to content

Import EasyEDA courtyard (layer 12) as pcb_courtyard_outline and update snapshots - #349

Open
seveibar wants to merge 1 commit into
mainfrom
codex/implement-courtyard-imports-and-update-snapshots
Open

Import EasyEDA courtyard (layer 12) as pcb_courtyard_outline and update snapshots#349
seveibar wants to merge 1 commit into
mainfrom
codex/implement-courtyard-imports-and-update-snapshots

Conversation

@seveibar

@seveibar seveibar commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

  • EasyEDA uses specific layers for courtyard/keepout artwork that should be preserved as courtyard geometry in Circuit JSON rather than silkscreen paths.

Description

  • Map EasyEDA TRACK and ARC shapes on layer 12 to pcb_courtyard_outline elements by adding handleCourtyardPath and handleCourtyardArc and importing pcb_courtyard_outline from circuit-json in lib/convert-easyeda-json-to-tscircuit-soup-json.ts.
  • Include pcb_courtyard_outline elements when computing pcb_component bounds so component width/height reflect courtyard geometry.
  • Add a focused regression test tests/convert-to-soup-tests/c14877-courtyard.test.ts and its SVG snapshot to verify courtyard import for C14877.

Testing

  • Ran BUN_UPDATE_SNAPSHOTS=1 bun test tests/convert-to-soup-tests/c14877-courtyard.test.ts, which passed and wrote the updated SVG snapshot.
  • Ran bun test tests/convert-to-ts/C14877.test.ts, which passed.
  • Ran typecheck with bunx tsc --noEmit, which succeeded.
  • Ran formatting with bun run format, which succeeded.
  • Note: a full run of BUN_UPDATE_SNAPSHOTS=1 bun test tests/convert-to-ts previously surfaced unrelated timeouts in other tests (C165948, C472489) that are not caused by this change.

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant