feat: add analog stimulus and measurements - #2908
Draft
ShiboSoftwareDev wants to merge 5 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
This PR intentionally remains a draft until the schema packages are merged and released:
The current CI failures are caused by npm resolving
circuit-json@0.0.455and@tscircuit/props@0.0.602, which predate the RFC records and props. After those two releases, this PR only needs their versioned dev-dependency bumps; peer dependencies remain*.Root cause of the probe fix
An explicit voltage probe and an implicit measurement probe could target the same SPICE vector. The later implicit metadata shadowed the explicit probe ID, so
getVoltage(...)could not find the returned transient graph. Implicit probes now share connectivity keys and are omitted when an equivalent explicit probe exists.Validation
bun test tests/features/spice-analysis/analog-transient-measurements.test.tsxbun test tests/features/spice-analysis(new and assertion-based tests pass; three pre-existing ngspice SVG snapshots drift under the local engine)bunx tsc --noEmitnpm pack --dry-run: the release tarball containsAnalogMeasurement, waveform handling, and measurement-result emissiongit diff --check