Apply crystal trace limits through routing DRC#2781
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…al-net-traces # Conflicts: # package.json
seveibar
marked this pull request as ready for review
July 24, 2026 19:18
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Crystalown its default/configured maximum trace-length behaviorCrystal.doInitialSourceDesignRuleChecks(), immediately after connectivity-map keys are generatedGroupand genericTraceutilitiesinsertPcbTraceTooLongWarningsmutation pathArchitecture
Core tees up Circuit JSON from the owning component: each crystal writes the effective constraint to matching
source_trace.max_lengthrecords during the source DRC phase. The normal boardrunDrcChecks→runAllRoutingCheckspipeline then emitspcb_trace_too_long_warningelements through the generic check released from tscircuit/checks#174.This PR now depends on the published
@tscircuit/checks@0.0.146release containing that generic check.Validation
@tscircuit/checks@0.0.146bunx tsc --noEmit