Add "sparkfun" to supplier_name enum#634
Draft
posthog[bot] wants to merge 1 commit into
Draft
Conversation
SparkFun is a legitimate electronics supplier, but it was missing from the
supplier_name enum. Setting supplierPartNumbers: { sparkfun: [...] } on a
component failed validation in source_component_base, blocking chip creation
entirely.
Generated-By: PostHog Code
Task-Id: 5909e5bc-a00e-4611-a731-c94c230eb4ed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
"sparkfun"to thesupplier_namezod enum (and the matchingSupplierNameunion type, kept in sync viaexpectTypesMatch).Why: SparkFun is a legitimate electronics supplier, but it was missing from the enum. Setting
supplierPartNumbers: { sparkfun: [...] }on a component failed validation insource_component_base, causing@tscircuit/coreto throw and blocking chip creation entirely with no in-tool workaround beyond dropping the supplier.Created with PostHog Code from an inbox report.