Fix isPointInPad treating oval/pill plated holes as rectangles#169
Open
abdalraof-albarbar wants to merge 1 commit into
Open
Fix isPointInPad treating oval/pill plated holes as rectangles#169abdalraof-albarbar wants to merge 1 commit into
abdalraof-albarbar wants to merge 1 commit into
Conversation
isPointInPad tested oval and pill plated holes against their bounding rectangle, so a point in the empty corner counted as on-pad and suppressed a real missing-connection error. Use an ellipse test for ovals and a stadium test for pills. Co-authored-by: abdalrouf-AAA <236259618+technologyet31-create@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isPointInPad tested oval and pill plated holes against their bounding rectangle, so a trace endpoint sitting in the empty corner of the bounding box counted as on-pad and suppressed a real missing-connection error. Use an ellipse test for ovals and a stadium test for pills.