feat: add via-to-pad clearance check#152
Open
harrrshall wants to merge 1 commit into
Open
Conversation
Adds checkViaPadClearance, a DRC check that flags vias placed too close to pads (pcb_smtpad and pcb_plated_hole). A via connected to the same net as a pad is ignored, since that proximity is intentional. Registered in runAllRoutingChecks and exported from index. Closes tscircuit#44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Adds a new DRC check,
checkViaPadClearance, that flags vias placed too close to pads (pcb_smtpadandpcb_plated_hole).Approach
outer_diameter) and measures the edge-to-edge gap to every pad.check-pad-pad-clearancetreats rectangular pads).check-via-trace-clearance.minClearanceis the board'smin_pad_edge_to_pad_edge_clearanceDRC value, falling back to the JLC minimum; overridable via the options argument.Registered in
runAllRoutingChecksand exported fromindex.ts.Tests
tests/lib/check-via-pad-clearance.test.tscovers a violation, a via far from the pad, a via connected to the pad's net, and a customminClearance. All four pass locally (bun test).Note
circuit-jsondoes not define apcb_via_pad_clearance_errortype yet, so the error interface is declared locally in the check. Promoting it tocircuit-jsonwould be a sensible follow-up — happy to do that if preferred.