Skip to content

Disable ingress session flag update #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rajiv91 wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Disable ingress session flag update #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2e01138
adding flag
Rajiv91 Dec 20, 2024
8c68e22
cleaning code
Rajiv91 Dec 20, 2024
3e3466c
protoc changed to 4.234
Rajiv91 Dec 30, 2024
8313f06
changing protoc-gen-go version
Rajiv91 Dec 30, 2024
3165692
changing protoc-gen-go version
Rajiv91 Dec 30, 2024
14d9f92
removing -I flag from magefile
Rajiv91 Dec 30, 2024
dc49762
session_enabled flag changed to enabled, CreateIngressReques includes…
Rajiv91 Jan 2, 2025
206432a
protoc-ge-go updated to 1.36.0 in boostrat script
Rajiv91 Jan 2, 2025
c11aae3
protoc-ge-go updated to 1.36.0 in boostrat script
Rajiv91 Jan 2, 2025
f5f90a3
protoc-ge-go-grpc updated in bootstrap.sh
Rajiv91 Jan 2, 2025
e668862
updating protoc-gen-psrpc
Rajiv91 Jan 2, 2025
4a81b4b
updating protoc-gen-psrpc in bootstrap.sh
Rajiv91 Jan 2, 2025
480a622
removed bootsrap versions update, validation error for non reusabled …
Rajiv91 Jan 6, 2025
1933f25
cloud_replay.pb.go updated to the used versions in remote repo and av…
Rajiv91 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ingress/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var (
ErrNoResponse = psrpc.NewErrorf(psrpc.Unavailable, "no response from ingress service")
ErrInvalidOutputDimensions = NewInvalidVideoParamsError("invalid output media dimensions")
ErrInvalidIngressType = psrpc.NewErrorf(psrpc.InvalidArgument, "invalid ingress type")
ErrIngressDisabled = psrpc.NewErrorf(psrpc.PermissionDenied, "session is disabled")
)

func ErrInvalidIngress(s string) psrpc.Error {
Expand Down
3 changes: 3 additions & 0 deletions ingress/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ func ValidateForSerialization(info *livekit.IngressInfo) error {
if info.Url == "" {
return ErrInvalidIngress("no source URL")
}
if !info.Enabled {
return ErrInvalidIngress("disabled non reusable ingress")
}
}

if info.ParticipantIdentity == "" {
Expand Down
Loading