fix(ci): drop Packagist secret requirement from release doctor#90
Merged
Conversation
Packagist publishing for trycourier/courier is handled by Packagist's GitHub auto-update hook (webhook fires on new tags), not a CI push, so the PACKAGIST_USERNAME / PACKAGIST_SAFE_KEY secrets are not needed. stainless.yml already sets php.publish.packagist: false (2025-11-12), but this generated check-release-environment was last synced 2025-10-07 and still fails the "release doctor" check when those secrets are absent — a false alarm that paints every release PR red even though Packagist is current (5.11.2). Make the check token-less, matching courier-node's OIDC check (which has an empty errors array and always passes). Publishing continues via the Packagist hook; this only removes the spurious red check. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every release PR shows a red release doctor check that fails in ~5s:
But Packagist publishing for
trycourier/courieris handled by Packagist's GitHub auto-update hook (webhook on new tags), not a CI push — so those secrets aren't needed. The package is current at 5.11.2, matching the latest tag, i.e. publishing already works with no token.Root cause
stainless.ymlalready setsphp.publish.packagist: false(2025-11-12), but this generatedbin/check-release-environmentwas last synced 2025-10-07 — before that change — so it still demands the Packagist secrets.courier-node, which needs no publish secrets (OIDC), generates an empty check that always passes. php should look the same.Fix
Make
check-release-environmenttoken-less (emptyerrorsarray, always "ready"), matching courier-node. Publishing continues via the Packagist hook; this only removes the spurious red check.Note
This is a Stainless-generated file. It only regenerates on a settings-sync (last one was 2025-10-07), and when it does it should come out token-less anyway (given
packagist: false), so this edit won't regress. The durable equivalent is a Stainless settings resync of this repo.🤖 Generated with Claude Code