fix: report TimeCamp verifier errors#4942
Open
Big-Comfy wants to merge 1 commit intotrufflesecurity:mainfrom
Open
fix: report TimeCamp verifier errors#4942Big-Comfy wants to merge 1 commit intotrufflesecurity:mainfrom
Big-Comfy wants to merge 1 commit intotrufflesecurity:mainfrom
Conversation
|
|
shahzadhaider1
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small scoped follow-up to #4051 for the TimeCamp detector.
Before this change, TimeCamp verification treated request failures and unexpected API responses the same as invalid credentials: the result came back unverified, with no
VerificationError. This keeps401and403as normal invalid-token responses, but records aVerificationErrorwhen the verifier cannot make a clean decision.The patch also adds a test-only client path so the verifier cases can be covered without hitting the live TimeCamp API.
Test plan
go test ./pkg/detectors/timecampgit diff --check