Adobe ims v2 (#4)#4909
Conversation
|
@kashifkhan0771 |
Due to some recent incidents where certain detectors either failed or generated too many false positives, we’ve introduced stricter requirements before merging any new detector. For now, please wait for approval before proceeding and then resolve any outstanding conflicts. If you have the time, you’re welcome to address them earlier as well. I'll add the Thank you for your submission and for helping make TruffleHog better! |
kashifkhan0771
left a comment
There was a problem hiding this comment.
I’ve completed an initial review and left some feedback. Once you’ve addressed those comments, I’ll pass this along to the prod-eng team for further review. The rest of the code looks good to me.
|
You need to rebase the branch with latest main and generate protos again - that should fix the conflicts. |
* Add Adobe IMS detector for access and refresh tokens Co-authored-by: Chivereanu Radu <37249331+Radu1999@users.noreply.github.com>
|
@kashifkhan0771 Thank you for the review! Done — rebased on latest main and regenerated protos. Let me know if anything else needs changes! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 64a7757. Configure here.

Add a new detector for Adobe IMS (Identity Management System) OAuth2 tokens. Adobe IMS issues JWT-based access tokens and refresh tokens for user authentication across Adobe services. This detector identifies tokens by decoding the JWT payload and checking for the "as" field prefixed with "ims-" (e.g. ims-na1, ims-eu1). Verification is done via POST /ims/validate_token/v1.
Closes #4908
[x] Tests passing (
make test-community)?[x] Lint passing (
make lintthis requires golangci-lint)?Note
Medium Risk
Adds a new JWT-based detector that performs optional live verification against Adobe IMS, introducing new outbound HTTP behavior and potential false positives/negatives despite input validation to reduce SSRF risk.
Overview
Adds a new
AdobeIMSdetector that scans for JWT-shaped strings, decodes the payload to identify Adobe IMS access/refresh tokens, and (optionally) verifies them viaPOST /ims/validate_token/v1with region-derived base URLs guarded by a strict allowlist regex.Registers the detector in the default detector list and extends
DetectorTypeprotobuf enums, with unit + integration tests covering matching behavior, request construction, and verification outcomes/timeouts.Reviewed by Cursor Bugbot for commit c49170f. Bugbot is set up for automated code reviews on this repo. Configure here.