Skip to content

NAS-140908 / 26.0.0-RC.1 / remove coloredlogs dep (by yocalebo)#356

Merged
yocalebo merged 1 commit into
stable/26from
NAS-140908-26.0.0-RC.1
May 5, 2026
Merged

NAS-140908 / 26.0.0-RC.1 / remove coloredlogs dep (by yocalebo)#356
yocalebo merged 1 commit into
stable/26from
NAS-140908-26.0.0-RC.1

Conversation

@bugclerk

@bugclerk bugclerk commented May 5, 2026

Copy link
Copy Markdown

No reason to carry a dependency just for this. This removes a transitive dependency (humanfriendly) as well.

Original PR: #355

@bugclerk

bugclerk commented May 5, 2026

Copy link
Copy Markdown
Author

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 5fce3ee1113e262800f43fb3563c164410b5eab0

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x af0c1adfc827ecf1d1fdedbbdbeb7cc763e33040

@bugclerk

bugclerk commented May 5, 2026

Copy link
Copy Markdown
Author

(cherry picked from commit 5fce3ee)
@yocalebo yocalebo force-pushed the NAS-140908-26.0.0-RC.1 branch from 054aad5 to 7bbc54f Compare May 5, 2026 14:00
@yocalebo yocalebo marked this pull request as ready for review May 5, 2026 14:00
@yocalebo yocalebo merged commit 86acda4 into stable/26 May 5, 2026
@yocalebo yocalebo deleted the NAS-140908-26.0.0-RC.1 branch May 5, 2026 14:01
@bugclerk

bugclerk commented May 5, 2026

Copy link
Copy Markdown
Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants