Skip to content

tnet: cover udp send error branches#35

Merged
WineChord merged 1 commit into
trpc-group:mainfrom
Rememorio:udp_send_tests
Jun 24, 2026
Merged

tnet: cover udp send error branches#35
WineChord merged 1 commit into
trpc-group:mainfrom
Rememorio:udp_send_tests

Conversation

@Rememorio

Copy link
Copy Markdown
Contributor

Summary

  • add direct Linux tests for UDP SendPackets with an empty outbound buffer
  • cover dropping a failed queued UDP datagram without returning an error
  • cover continuing to send later queued UDP datagrams after a failed packet

CI Alignment

I compared the current tnet workflow with trpc-go. The main red status after #34 is Codecov patch coverage, not a GitHub Actions failure. The tnet push workflow is already green after #33 restricted lint and apidiff to pull requests, so this PR keeps workflow configuration unchanged and focuses on the missing UDP send coverage.

Validation

  • go test -run 'TestUDPConnWriteToDropsFailedPacketAndContinues|TestNetFDSendPackets' -v -count=1
  • go test -coverprofile=/tmp/tnet_root.cover .
  • go test ./...

@WineChord WineChord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WineChord WineChord merged commit b2912dd into trpc-group:main Jun 24, 2026
6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants