tnet: keep udp poller active after send errors#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
UDP async writes can enqueue packets in
outBufferand rely on poller write events to flush them. Ifsendmmsgreturns a non-EAGAIN error for the queued head packet,udpOnWritepreviously returned that error to the poller. The poller then detached the shared UDP listener fd, while the UDP connection object stayed active withwritingheld and queued packets left inoutBuffer.Validation
go test -run TestUDPConnWriteToDropsFailedPacketAndContinues -v -count=1go test -run 'TestUDPConnWriteToDropsFailedPacketAndContinues|Test_netFD' -v -count=1go test ./...Fixes #26