Skip to content

ci: fix push checks#33

Merged
Rememorio merged 1 commit into
trpc-group:mainfrom
Rememorio:fix_push_ci_reuseport
Jun 18, 2026
Merged

ci: fix push checks#33
Rememorio merged 1 commit into
trpc-group:mainfrom
Rememorio:fix_push_ci_reuseport

Conversation

@Rememorio

@Rememorio Rememorio commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Run golangci-lint only for pull requests, where only-new-issues has the required diff context.
  • Keep golangci-lint on latest while avoiding push-event failures from repository-wide historical lint issues.
  • Add Codecov configuration that keeps patch coverage gated at 85% while making project coverage informational.
  • Use platform-specific SO_REUSEPORT values and stop reuseport tests from panicking after setup failures.

Validation

  • go test ./internal/reuseport -count=1 -v
  • go test ./... -count=1
  • cd extensions/websocket && go test ./... -count=1
  • cd examples && go test ./... -count=1
  • go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8 run --new-from-rev=upstream/main
  • GOOS=linux GOARCH=amd64 go test -c ./internal/reuseport

@Rememorio Rememorio force-pushed the fix_push_ci_reuseport branch from d779096 to 8246619 Compare June 18, 2026 06:21
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.58308%. Comparing base (6b64c61) to head (8246619).

Additional details and impacted files
@@              Coverage Diff              @@
##                main         #33   +/-   ##
=============================================
  Coverage   78.58308%   78.58308%           
=============================================
  Files             48          48           
  Lines           4291        4291           
=============================================
  Hits            3372        3372           
  Misses           688         688           
  Partials         231         231           
Flag Coverage Δ
unittests 78.58308% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rememorio Rememorio force-pushed the fix_push_ci_reuseport branch from 8246619 to 5eaae9a Compare June 18, 2026 06:31

@WineChord WineChord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rememorio Rememorio merged commit 4aa3e51 into trpc-group:main Jun 18, 2026
6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants