Accommodate Rails 7.2 & Ruby 3.4#513
Merged
Merged
Conversation
seanaery
commented
Sep 18, 2025
seanaery
commented
Collaborator
- Permit using Rails 7.2 (7.1 reaches EOL in Oct 2025).
- Constrain blacklight_hierarchy gem under 6.6.0 (changes to its JS & CSS past that version will break things in TRLN Argon necessitating more refactoring work, TBD whether it will ever be needed).
- Constrain view_component gem under 4.0 (using 4 would require more refactoring, TBD whether it will ever be needed)
- Add Ruby 3.4 to our test matrix
- Get rubocop tests passing
- 6.6.0+ introduces a JS rewrite that does not work for TRLN Argon
- 4.0+ requires ruby 3.3+ and would also necessitate changes to several files
- Note: only doing the bare minimum here to limit the complexity of updating to Rails 7.2
Contributor
|
These changes were tested at NC State with the latest code base and there were no obvious problems (i.e. most basic functions were tested and found to work). |
Contributor
|
I will merge this if we bump the version to |
Collaborator
Author
|
Good idea @adjam . It is now bumped to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.