Skip to content

Bump compat bounds to reflect current Trixi v0.16.10 state#192

Merged
benegee merged 10 commits into
mainfrom
bg/trixi-0-16-10
May 27, 2026
Merged

Bump compat bounds to reflect current Trixi v0.16.10 state#192
benegee merged 10 commits into
mainfrom
bg/trixi-0-16-10

Conversation

@benegee

@benegee benegee commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Closes #177, closes #178, closes #180, closes #184.

Comment thread docs/Project.toml Outdated
@benegee

benegee commented May 22, 2026

Copy link
Copy Markdown
Collaborator Author

I did some adaptations as done in trixi-framework/Trixi.jl#2910, thanks @JoshuaLampert !

There is a slight change in the errors for the Held Suarez test case. It's the only elixir using RDPK3SpFSAL49.

@JoshuaLampert

Copy link
Copy Markdown
Member

We also had one slightly changing error value in Trixi.jl. Maybe it is the same root cause, see trixi-framework/Trixi.jl#2910 (comment).

@benegee

benegee commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the reference!

@JoshuaLampert

Copy link
Copy Markdown
Member

I hope the final failing tests will be fixed by 938736c. This is due to changes in RecursiveArrayTools.jl v4. We also had a similar issue in Trixi.jl, see trixi-framework/Trixi.jl#2910 (comment).

@benegee

benegee commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks a lot for helping out!

Comment thread Project.toml
Comment thread docs/Project.toml Outdated
Comment thread docs/Project.toml Outdated
@codecov

codecov Bot commented May 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.11%. Comparing base (8ebf7f6) to head (1b605db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          38       38           
  Lines        5128     5128           
=======================================
  Hits         4980     4980           
  Misses        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

@JoshuaLampert JoshuaLampert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@benegee benegee enabled auto-merge (squash) May 27, 2026 14:59
@benegee benegee merged commit a42e98d into main May 27, 2026
10 checks passed
@benegee benegee deleted the bg/trixi-0-16-10 branch May 27, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants