handle in path params#5
Open
DIDONAX wants to merge 2 commits into
Open
Conversation
| std::ostream& header, | ||
| std::ostream& source); | ||
|
|
||
| void gen_member_init_from_seg(YAML::Node const& root, |
Contributor
There was a problem hiding this comment.
not used outside its own source file -> remove definition from header
| @@ -0,0 +1,33 @@ | |||
| #include "gtest/gtest.h" | |||
|
|
|||
| #include "openapi/bad_request_exception.h" | |||
| T parse_segment(boost::urls::segments_view const& segs, | ||
| std::string_view name, | ||
| std::size_t idx) { | ||
| auto it = segs.begin(); |
Contributor
There was a problem hiding this comment.
it only needed in if block
| if (sv.ends_with('}')) { | ||
| sv.remove_suffix(1); | ||
| } | ||
| seg_idx.emplace(sv, i - 1); |
| std::ostream& header, | ||
| std::ostream& source) { | ||
| const auto p = path.as<std::string_view>(); | ||
| auto segs = p | std::views::split('/'); |
Contributor
There was a problem hiding this comment.
should be inlined (not used afterwards and name is not telling anything)
Comment on lines
+443
to
+444
| auto const in_path = | ||
| p["in"].IsDefined() && p["in"].as<std::string_view>() == "path"; |
Contributor
There was a problem hiding this comment.
don't repeat yourself - write a utility function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.