test: wait for focus to settle in carousel tests#637
Merged
Conversation
The instant-snap and stacking steps acted on client.focus before it settled, so a late focus-on-manage could leave the carousel centered on the wrong client (flaky headless, ~20% of runs). Poll until focus lands on the target client before asserting geometry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two carousel integration tests acted on
client.focusbefore it had settled. A client still finishing its map could grab focus via focus-on-manage right after the test setclient.focus = c1, leaving the carousel centered on the wrong client.test-carousel-vertical-animationthen hard-asserted geometry on a fixed poll (c1landed a full screen above the workarea), andtest-carousel-stackingran its consume against the wrong column. Both flaked in roughly 20% of headless runs.Both steps now poll until
client.focusactually lands on the target client before asserting, so a late focus-on-manage can no longer decide the outcome. Test-only change; no compositor or library code touched.Test Plan
Checklist
lua/awful/,lua/gears/,lua/wibox/,lua/naughty/) are not modified — if a bug surfaces in Lua, the fix belongs in Cmake test-unit && make test-integration)