fix(input): handle KeyRelease events#629
Merged
Merged
Conversation
sicelo
force-pushed
the
fix/key-release-events
branch
from
c1d54a5 to
ec2a563
Compare
sicelo
force-pushed
the
fix/key-release-events
branch
from
ec2a563 to
63b0858
Compare
Closes trip-zip#620 Signed-off-By: Sicelo A. Mhlongo <absicsz@gmail.com>
JimmyCozza
force-pushed
the
fix/key-release-events
branch
from
63b0858 to
c4d0683
Compare
JimmyCozza
approved these changes
Jul 9, 2026
JimmyCozza
left a comment
JimmyCozza
left a comment
Contributor
There was a problem hiding this comment.
@sicelo thanks!
Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620
Description
Adds handling for KeyRelease events. Currently somewm is hardcoded to only handle KeyPress events.
Test Plan
Used the configuration from #620
Checklist
lua/awful/,lua/gears/,lua/wibox/,lua/naughty/) are not modified — if a bug surfaces in Lua, the fix belongs in Cmake test-unit && make test-integration)