Require plugins to bind mbeans in namespace#28864
Closed
findepi wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
hudi
wendigo
approved these changes
Mar 25, 2026
`MBeanModule` is used by almost every connector. By default, it exports mbeans into global namespace, which is confusing. Disallow direct use of that module. Instead, require to use a wrapper that verifies an `ObjectNameGenerator` is properly bound.
findepi
force-pushed
the
user/findepi/jmxplugins
branch
from
4b0ccc7 to
857253f
Compare
Member
Author
|
it's a mess. We don;'t have a config name generator that could export from base-jdbc and from eg trino-postgresql . Those names are hard to update in tests, hard to export consistently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MBeanModuleis used by almost every connector. By default, it exports mbeans into global namespace, which is confusing. Disallow direct use of that module. Instead, require to use a wrapper that verifies anObjectNameGeneratoris properly bound.