Skip to content

Stop logging parser noise and propagate phantom-parse errors #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobDu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop logging parser noise and propagate phantom-parse errors #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions precise/src/QueryEditorPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,6 @@ class QueryEditorPane extends React.Component<QueryEditorPaneProps, QueryEditorP
endWord = i
}

// In parseAndDecoratePromise, after calculating currentWord:
console.log('Current word being parsed:', currentWord)
console.log('Cursor position:', caretPosition.lineNumber, caretPosition.column)
console.log('Word bounds:', startWordColumn, 'to', endWord)

const inputStream = CharStream.fromString(newValue)
const lexer = new SqlBaseLexer(inputStream)
const tokenStream = new CommonTokenStream(lexer)
Expand Down Expand Up @@ -316,6 +311,8 @@ class QueryEditorPane extends React.Component<QueryEditorPaneProps, QueryEditorP
const parserWithChar = new SqlBaseParser(tokenStreamWithChar)
const listenerWithChar = new SqlBaseListenerImpl(this.props.catalog, this.props.schema)
parserWithChar.addParseListener(listenerWithChar)
parserWithChar.removeErrorListeners()
parserWithChar.addErrorListener(errors)
const treeWithChar = parserWithChar.singleStatement()
currentTreePosition = this.parseTreeFromPosition(
treeWithChar,
Expand Down