Conversation
added 5 commits
May 29, 2026 01:37
…d its functions/features/goals.
Transition Trident to modern Go Modules, clean up legacy GOPATH, and fix struct initializations.
Summary of Changes:
1. Go Module Transition & Clean Up (Phase 1.1)
- GitHub Migration: Configured go.mod to fetch pitchfork and go dependencies directly from their public GitHub repositories instead of relying on legacy local checkouts in ext/_gopath.
- Vanity Import Fix: Resolved an issue where trident.li/keyval vanity import redirects were failing by pointing the replace directive directly to the correct public GitHub repository (github.com/secludedsoc/keyval).
- Makefile Modernization: Cleaned up the Makefile to remove legacy GOPATH exports and complex dependency cloning targets. It now exclusively uses standard Go toolchain commands (go vet, go test, go fmt).
- Dependency Tidy: Ran go mod tidy to lock versions and update go.sum.
2. Code Quality & Static Analysis (Phase 1.2)
- Struct Keying: Refactored all PfMEntry and PfUIMentry struct initializations across the codebase to use keyed fields, resolving all go vet warnings. Affected files:
* src/lib/group.go
* src/lib/group_attestation.go
* src/lib/user.go
* src/lib/vouch.go
* src/ui/group.go
* src/ui/root.go
3. Plan Update
- Marked Phase 1 as completed in doc/modernization/modernization_plan.md.
TAG=agy
CONV=966de079-9753-4c5b-925b-481132adaa66
morrowc
changed the title
Collaborator
Author
|
I can't see vixie yet, but .... ;) |
Collaborator
Author
|
Cool, now sent to vixie. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focus on its functions/features/goals, this is robot created, so it may need some massage.
Additionally, implement the first phase of the modernization plan proposed.