release: cut v1.0.1 — fix javadoc refs broken during v1.0 rename#44
Merged
Conversation
The v1.0.0 Maven Central publish failed because two javadoc
{@link Result#tables()} references survived the
@table → @dataset rename (BindRow.java line 16 and
ResultAccessorsTest.java line 15). The strict javadoc check inside
the publish workflow fails the build; nothing reaches Maven Central.
Fix updates both references to {@link Result#datasets()}, bumps
the Gradle version from 1.0.0 to 1.0.1, and adds a [1.0.1] section
to the CHANGELOG. No code or wire-format change versus v1.0.0; the
v1.0.0 tag remains in git for archaeology, but its Maven Central
artifact was never published.
After merge, tag v1.0.1 on main; publish workflow re-runs against
the clean javadoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch release fixing the v1.0.0 Maven Central publish failure.
Two javadoc
{@link Result#tables()}references survived the@table→@datasetrename (inBindRow.javaline 16 andResultAccessorsTest.javaline 15). The strict javadoc check inside the publish workflow fails the build on `reference not found`, so nothing reached Maven Central. Other ports (Go, TypeScript) tagged and published v1.0.0 cleanly.What's in
{@link Result#datasets()}.build.gradle.kts:version = "1.0.0"→"1.0.1".CHANGELOG.md: new[1.0.1] — 2026-05-13section.No code or wire-format change vs v1.0.0
This is purely a build-system fix to land the v1.0.0 contents on Maven Central. The v1.0.0 tag stays in git for archaeology, but its Maven artifact was never published.
After merge
Tag
v1.0.1on main; the publish workflow re-runs with the clean javadoc.Why a v1.0.1 instead of force-retagging v1.0.0
Tag protection ruleset blocks deletion/update of
refs/tags/v*.*.*. v1.0.1 is the correct SemVer response to a build break on a tagged release anyway.Lockstep version table after this lands: