Feature validate spec#1188
Open
dylanmartin wants to merge 11 commits into
Open
Conversation
This was
linked to
issues
Feb 4, 2022
Contributor
|
So I think a good goal here would be to get SSR validating fully. What that'll mean is that on pipeline save the owner fields need to be filled out to a minimum, this might just mean checking if the obj exists rather than the entire semantic fulfillment, and on mapping which will mean member fields have also been filled out to the same standard |
Collaborator
Author
|
This validates on the input spec when it comes from the UI when saving a pipeline. Is the validation that happens here identical to what should happen when uploading a spec in simulator? is inputMap in the same form here as in other places? Aside from the UI, where should the validator be used? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds validation to inputMap when saving a pipeline.
What is the current behavior? (You can also link to an open issue here)
closes _issue #_1184
What is the new behavior (if this is a feature change)?
Adds validation to inputMap when saving a pipeline.