Skip to content

Fix for problem in CC2420 read caused by a wrong variable name. #51

Open
inode- wants to merge 1 commit into
travisgoodspeed:masterfrom
inode-:master
Open

Fix for problem in CC2420 read caused by a wrong variable name. #51
inode- wants to merge 1 commit into
travisgoodspeed:masterfrom
inode-:master

Conversation

@inode-

@inode- inode- commented Nov 20, 2020

Copy link
Copy Markdown

Fix for problem in CC2420 read caused by a wrong variable name usage and a change of the logic.

This error cause a fail read on data from the CC2420.

The bug has been introduced in 16391a9

…error cause a fail read on data from the CC2420.
@rmspeers

rmspeers commented Jan 9, 2022

Copy link
Copy Markdown
Collaborator

This shows a change of i to ret which seems to make sense in this case, however it also has another line which the comment indicates it's unclear why it's needed. Any insight into where this was seen to be helpful, or what happened when testing without it?

@inode-

inode- commented Jan 9, 2022

Copy link
Copy Markdown
Author

I'm pretty sure it was a duplicate check, but honestly after 1 year I don't remember anything. Surely an extra check doesn't hurt ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants