Skip to content

feat(output): show loss with two decimals#645

Merged
rewolff merged 1 commit into
traviscross:masterfrom
Komzpa:darafei/loss-percent-precision
May 25, 2026
Merged

feat(output): show loss with two decimals#645
rewolff merged 1 commit into
traviscross:masterfrom
Komzpa:darafei/loss-percent-precision

Conversation

@Komzpa

@Komzpa Komzpa commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • show Loss% with two decimal places in shared output field formatting
  • align the GTK percentage formatter with the same precision
  • add report-mode coverage that checks 0.00% is printed for a no-loss localhost run

Fixes #350.

Tests

  • git diff --check
  • ./bootstrap.sh && ./configure --without-gtk --without-jansson && make -j "$(nproc)"
  • sudo python3 ./test/cmdparse.py
  • sudo ./mtr --report --report-cycles 1 --no-dns 127.0.0.1 | sed -n '1,3p'

@rewolff

rewolff commented May 25, 2026

Copy link
Copy Markdown
Collaborator

@Komzpa , I'm guessing I'm approving things in the wrong order. Sorry. This one now has merge conflicts. Could you look into them?

@Komzpa Komzpa force-pushed the darafei/loss-percent-precision branch from 5b28e21 to c6cedf3 Compare May 25, 2026 11:45
@Komzpa

Komzpa commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@rewolff I rebased pending PRs

@rewolff rewolff merged commit c6cedf3 into traviscross:master May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decimal precision of "Loss%"

2 participants