test(options): cover quoted MTR_OPTIONS order#644
Merged
rewolff merged 2 commits intoMay 25, 2026
Conversation
Komzpa
force-pushed
the
darafei/mtr-options-quoted-order-test
branch
from
61cf1cd to
a6c0960
Compare
Komzpa
force-pushed
the
darafei/mtr-options-quoted-order-test
branch
from
a6c0960 to
2175eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MTR_OPTIONS='--order "SRDL NBAGVW JMXI"'The parser behavior is already fixed on current
masterby the earlier quoted-MTR_OPTIONSparser work; this PR adds the missing regression coverage for the exact #324 scenario.Refs #324.
Tests
git diff --check./bootstrap.sh && ./configure --without-gtk --without-jansson && make -j "$(nproc)"sudo python3 ./test/cmdparse.py