Skip to content

test(output): cover bad host exit status#642

Merged
rewolff merged 4 commits into
traviscross:masterfrom
Komzpa:darafei/bad-host-exit-tests
May 25, 2026
Merged

test(output): cover bad host exit status#642
rewolff merged 4 commits into
traviscross:masterfrom
Komzpa:darafei/bad-host-exit-tests

Conversation

@Komzpa

@Komzpa Komzpa commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add regression coverage for failed hostname resolution in non-interactive output modes
  • verify --csv, --raw, --report, --xml, and --json when available all return non-zero and print the resolver error

Fixes #294.

The current code already exits non-zero in these cases; this keeps the historical --csv/--raw/--json failure mode covered.

Tests

  • git diff --check
  • ./bootstrap.sh && ./configure --without-gtk --without-jansson && make -j "$(nproc)"
  • sudo python3 ./test/cmdparse.py

@rewolff

rewolff commented May 8, 2026 via email

Copy link
Copy Markdown
Collaborator

@Komzpa

Komzpa commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

@rewolff please do not be stressed about it, there is no rush, and thanks for taking the time to review and merge the things you merged already. I hope the patches are useful; but if ticket was there since 2017 it can probably wait a bit longer so everyone can have a balanced life.

@Komzpa Komzpa force-pushed the darafei/bad-host-exit-tests branch from d354a81 to 2e877de Compare May 9, 2026 09:45
@Komzpa Komzpa force-pushed the darafei/bad-host-exit-tests branch from 2e877de to 8c229ce Compare May 25, 2026 11:45
@rewolff rewolff merged commit 8c229ce into traviscross:master May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return exit code when host not found

2 participants