curses: add report snapshot on exit#584
Closed
Komzpa wants to merge 1 commit into
Closed
Conversation
This was referenced May 7, 2026
Contributor
Author
|
Superseded by #580, which now carries both curses startup/exit controls so the merge stack no longer has an internal option-plumbing conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--report-on-exitflag for the curses interfacemtr(8)and--helpThis follows the workaround discussed in #323 without changing the default curses behavior for existing users.
Fixes #323.
Validation
git diff --check./bootstrap.sh./configure --without-gtk --without-janssonmake -j "$(nproc)"sudo python3 ./test/cmdparse.pyuv run --python 3.9 --with flake8==3.9.2 --with flake8-bandit==2.1.2 --with bandit==1.7.2 --with pbr==7.0.3 python -m flake8 ../mtr --help 2>&1 | grep -F -- --report-on-exitscript -q -e -c "sh -c 'sleep 1; printf q' | ./mtr --report-on-exit --curses --no-dns --max-ttl 1 localhost" /tmp/mtr-report-on-exit.typescript