build: search terminal info libraries#579
Merged
rewolff merged 1 commit intoMay 25, 2026
Merged
Conversation
Refresh the libtinfo lookup originally proposed in PR traviscross#368 for the current ncursesw/ncurses configure path. Co-authored-by: Darafei Praliaskouski <me@komzpa.net>
4163460 to
20dd4bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search terminal-info libraries when curses support is enabled.
Some distributions split terminal state functions out of ncurses/ncursesw, so linking curses code can require an additional
tinfow,tinfo, ortermcaplibrary. This is a refreshed version of the old #368 idea, withtinfowchecked first so the current ncursesw path keeps the matching wide-character terminal-info library when needed.Supersedes #368.
Authorship note: the branch keeps Jeroen Roovers as the commit author for the refreshed #368 libtinfo lookup, with the current-tree adaptation co-authored by Darafei.
Validation
./bootstrap.sh./configure --without-gtk --without-janssonwprintw,initscr, andrawmake -j $(nproc)git diff --checkuv run --python 3.9 --with flake8==3.9.2 --with flake8-bandit==2.1.2 --with bandit==1.7.2 --with pbr==7.0.3 python -m flake8 .The build still prints the existing
ui/split.csnprintftruncation warnings on this compiler; those warnings are present on the current code path and are not introduced by this PR.