Skip to content

Codex/next features#7

Merged
travelhawk merged 2 commits into
masterfrom
codex/next-features
May 26, 2026
Merged

Codex/next features#7
travelhawk merged 2 commits into
masterfrom
codex/next-features

Conversation

@travelhawk

Copy link
Copy Markdown
Owner

Summary

  • Simplify target push and skill installs
  • Removed local targets. There are only global push targets now.

Validation

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • pnpm smoke if user-facing CLI behavior changed

Release Impact

  • none
  • patch
  • minor
  • major

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e2610aa03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 597 to 601
const request = resolveProviderInstallRequest(
sourceOrSelector,
options.skills ?? [],
options.provider,
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use resolved provider request for repo-or-URL installs

installProviderSkill now classifies plain repo/URL input via resolveProviderInstallInput, but it discards that result and always rebuilds the request with resolveProviderInstallRequest(sourceOrSelector, options.skills, ...). For inputs like agentpm skills install github:owner/repo (or any repo/URL without --skill), options.skills is empty so resolveProviderInstallRequest forces selector parsing and throws Expected a provider selector like "owner/repo@skill-name" instead of continuing with one-off source install selection. This breaks the newly documented skills install <repo-or-url> flow.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex: please address this issue

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Fixed installProviderSkill to reuse the request returned by resolveProviderInstallInput instead of always reconstructing from sourceOrSelector and options.skills, which preserves repo/URL one-off install behavior without incorrectly forcing selector parsing. packages/core/src/service.tsL566-L609
  • After interactive query selection, the code now re-resolves the selected value through resolveProviderInstallInput so the downstream request is normalized consistently before install execution. packages/core/src/service.tsL594-L600
  • Committed the change as: fix(core): reuse resolved provider install request for repo/url installs (commit c92869a).

Testing

  • pnpm --filter @agentpm/core test

View task →

@travelhawk travelhawk merged commit 15c67a6 into master May 26, 2026
3 checks passed
@travelhawk travelhawk deleted the codex/next-features branch June 12, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant