Codex/next features#7
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e2610aa03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const request = resolveProviderInstallRequest( | ||
| sourceOrSelector, | ||
| options.skills ?? [], | ||
| options.provider, | ||
| ); |
There was a problem hiding this comment.
Use resolved provider request for repo-or-URL installs
installProviderSkill now classifies plain repo/URL input via resolveProviderInstallInput, but it discards that result and always rebuilds the request with resolveProviderInstallRequest(sourceOrSelector, options.skills, ...). For inputs like agentpm skills install github:owner/repo (or any repo/URL without --skill), options.skills is empty so resolveProviderInstallRequest forces selector parsing and throws Expected a provider selector like "owner/repo@skill-name" instead of continuing with one-off source install selection. This breaks the newly documented skills install <repo-or-url> flow.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Fixed
installProviderSkillto reuse the request returned byresolveProviderInstallInputinstead of always reconstructing fromsourceOrSelectorandoptions.skills, which preserves repo/URL one-off install behavior without incorrectly forcing selector parsing. packages/core/src/service.tsL566-L609 - After interactive query selection, the code now re-resolves the selected value through
resolveProviderInstallInputso the downstream request is normalized consistently before install execution. packages/core/src/service.tsL594-L600 - Committed the change as:
fix(core): reuse resolved provider install request for repo/url installs(commitc92869a).
Testing
- ✅
pnpm --filter @agentpm/core test
Summary
Validation
pnpm lintpnpm typecheckpnpm testpnpm buildpnpm smokeif user-facing CLI behavior changedRelease Impact