Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Package pkg renamed into internal vol.2 - #8

Open
piotrkowalczuk wants to merge 5 commits into
travelaudience:masterfrom
piotrkowalczuk:feature/internal-package
Open

Package pkg renamed into internal vol.2#8
piotrkowalczuk wants to merge 5 commits into
travelaudience:masterfrom
piotrkowalczuk:feature/internal-package

Conversation

@piotrkowalczuk

Copy link
Copy Markdown

New attempt to move files located in pkg directory into internal. A completely fresh start as it was quite impossible to rebase the branch after so many changes. Plus I don't have permission to origin anymore.

I encountered an issue:

internal/admission/webhook.go:49:2: unknown import path "github.com/travelaudience/aerospike-operator/internal/client/clientset/versioned": cannot find module providing package github.com/travelaudience/aerospike-operator/internal/clien
t/clientset/versioned
cmd/operator/main.go:42:2: unknown import path "github.com/travelaudience/aerospike-operator/internal/client/clientset/versioned/scheme": cannot find module providing package github.com/travelaudience/aerospike-operator/internal/client/
clientset/versioned/scheme
cmd/operator/main.go:43:2: unknown import path "github.com/travelaudience/aerospike-operator/internal/client/informers/externalversions": cannot find module providing package github.com/travelaudience/aerospike-operator/internal/client/
informers/externalversions
internal/backuprestore/handler.go:35:2: unknown import path "github.com/travelaudience/aerospike-operator/internal/client/listers/aerospike/v1alpha2": cannot find module providing package github.com/travelaudience/aerospike-operator/int
ernal/client/listers/aerospike/v1alpha2

I'm not able to find github.com/travelaudience/aerospike-operator/pkg/client package on master.

cc @pires

It is related to #1.

@pires

pires commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

@piotrkowalczuk you have to run make gen.

@piotrkowalczuk

Copy link
Copy Markdown
Author

Done. A few tests are failing, the same that fails on the master.


@pires do you consider any package from internal (originally pkg) directory to be for public use only?

@pires pires left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to be honest with you and while looking at these changes I'm asking myself if whatever gains justify the effort and risk they carry. I wanted to be inclusive and take in mind any contributions, and I know you've tried to contribute long time ago, but I'm a bit anxious 😅

Comment thread hack/update-openapi.go Outdated

@piotrkowalczuk piotrkowalczuk left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pires Up to you man ;)

Comment thread hack/update-openapi.go Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants