This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Package pkg renamed into internal vol.2 - #8
Open
piotrkowalczuk wants to merge 5 commits into
Open
Conversation
Contributor
|
@piotrkowalczuk you have to run |
Author
|
Done. A few tests are failing, the same that fails on the master. @pires do you consider any package from |
pires
reviewed
Jun 4, 2019
pires
left a comment
Contributor
There was a problem hiding this comment.
I have to be honest with you and while looking at these changes I'm asking myself if whatever gains justify the effort and risk they carry. I wanted to be inclusive and take in mind any contributions, and I know you've tried to contribute long time ago, but I'm a bit anxious 😅
piotrkowalczuk
commented
Jun 4, 2019
piotrkowalczuk
left a comment
Author
There was a problem hiding this comment.
@pires Up to you man ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New attempt to move files located in
pkgdirectory intointernal. A completely fresh start as it was quite impossible to rebase the branch after so many changes. Plus I don't have permission to origin anymore.I encountered an issue:
I'm not able to find
github.com/travelaudience/aerospike-operator/pkg/clientpackage onmaster.cc @pires
It is related to #1.