Update NewClient to accept a pointer to Options instead of a value#997
Open
roger2hk wants to merge 1 commit into
Open
Update NewClient to accept a pointer to Options instead of a value#997roger2hk wants to merge 1 commit into
NewClient to accept a pointer to Options instead of a value#997roger2hk wants to merge 1 commit into
Conversation
roger2hk
force-pushed
the
tlog-mirror-new-client
branch
from
1c36476 to
aec0bb6
Compare
…e and add unit tests
roger2hk
force-pushed
the
tlog-mirror-new-client
branch
from
aec0bb6 to
c517c72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #945.