Properly serialize trp's extra_attributes#26
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 94.66% 94.78% +0.12%
==========================================
Files 15 15
Lines 1030 1035 +5
==========================================
+ Hits 975 981 +6
+ Misses 55 54 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for storing and serializing extra custom attributes on
TrustedResearchPerformanceobjects. These extra attributes can now be passed when adding a performance, are included in the JSON-LD output, and are preserved through save/load cycles. The changes also include a new test to verify this functionality.Support for extra attributes on performances:
extra_attributesfield to theTrustedResearchPerformancemodel to store arbitrary custom key-value pairs.to_jsonldmethod to include anyextra_attributesin the serialized output.extra_attributes. [1] [2]add_performancemethod in the TRO model to setextra_attributesdirectly on the performance object.Testing:
test_add_performance_extra_attrs) to ensure that extra attributes passed toadd_performanceare correctly included and persisted.