fix(mission): clear error when the waypoint CSV has no waypoints#7
Merged
Conversation
setup() in both the WPML and KML builders did cpt_csv_properties[-1] on a copy of an empty wpt list when a CSV had zero type='wpt' rows, raising a cryptic IndexError. Raise a clear ValueError naming the CSV instead. Regression test on the WPML builder (no network).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the waypoint CSV contains no
wptrows,BuildTemplateKML.setupandBuildWaylinesWPML.setupcrashed deep in setup with an opaqueIndexErroroncpt_csv_properties[-1].Both now raise a clear
ValueErrorup front when there are zero waypoints, naming the CSV path and stating that a mission needs at least one waypoint.Adds a regression test for the empty-waypoint case. 22 tests pass.
AI (Claude) supported my development of this PR.