feat(tsp): make OR-Tools solver time limit configurable#5
Merged
Conversation
The TSP time limit was hardcoded to 30s in solve_tsp_ortools. OR-Tools' guided-local-search runs the full budget even after the optimum is found, so large surveys could not extend it and the unit tests each burned 30s. Add a tsp_time_limit_seconds config field (default 30, behaviour-preserving), thread it through BuildCSV to the solver, and let the route tests use a short budget — suite drops from ~151s to ~12s. Adds a test for the new parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TSP solver time limit was hardcoded to 30s in
solve_tsp_ortools. OR-Tools' guided-local-search runs the full budget even after it has found the optimum, so:This adds a
tsp_time_limit_secondsconfig field (default 30, behaviour-preserving), threads it throughBuildCSVto the solver, and lets the route tests use a short budget. The suite drops from ~151s to ~12s. A test for the new parameter is included.19 tests pass.
AI (Claude) supported my development of this PR.