Add optional query param for adding headers to the server's response#146
Open
moritzschmitz-oviva wants to merge 1 commit into
Open
Conversation
ldez
reviewed
Apr 9, 2025
Contributor
|
Note, this doesn't fix #31 because this issue was not related to query parameters but to a request without any arguments. |
ldez
reviewed
Apr 9, 2025
ldez
reviewed
Apr 9, 2025
Author
|
@ldez Thank you for the input! |
mmatur
force-pushed
the
feature/add-response-header-param
branch
from
fc653de to
bf1aefd
Compare
mmatur
approved these changes
May 22, 2025
Author
|
@mmatur I think your review got stale? |
Author
Add `?header=key=value` query parameter support to the root handler. Multiple headers can be added by repeating the param, e.g. `/?header=Cache-Control=no-cache&header=X-Foo=bar`.
moritzschmitz-oviva
force-pushed
the
feature/add-response-header-param
branch
from
6180c93 to
609edbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a feature to allow setting response headers via query params.
Derived from #31.