Rewrite MATLAB import functions with readstruct()#350
Open
Jerry1144 wants to merge 2 commits into
Open
Conversation
Rewritten MATLAB import functions with readstruct(), available since R2020b Shifting to MATLAB's own capabilities helps alleviate Java heap size problems. MATLAB's memory use will skyrocket during run, but memory pressure will not. Caveat: readstruct() automatically converts imported data into "appropriate" forms, and there's no control over that.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One path to #343, rewriting MATLAB import functions with
readstruct(). Shifting to MATLAB's own capabilities helps alleviate Java heap size problems. Force push of #344Specific to this path:
readstructreads everything, so I let trackmateFeatureDeclarations() be the only place (among Spots, Edges, and Graph) that reads the XML, and pass that around as a secret global variable.readstructattempts to detect data types of attributes, so there are tests for "is it imported as double" littered everywhere.<Model>node, just to fetch its attributes, but there's no choice of "read attribute only" from readstruct(). I see no reasonable way to do it. notmatlab.io.xml.dom.*either, which isn't there yet.