Bugfix: Fix/forward type config#37
Conversation
|
Looks like this has unrelated commit. |
cd3fcc1 to
5622ee6
Compare
|
Oops. Fixed. |
63aedfd to
d94208a
Compare
|
@filippolmt - is this one of interest? |
f7e715e to
62e252d
Compare
- Update forward configuration to use proper type field - Improve configuration schema structure for better compatibility - Add configurable probe settings for deployment flexibility
3edfc64 to
df870ff
Compare
|
The failing check is due to a missing/out-of-date image tag. Not related to the changes. |
4bfdeb2 to
df870ff
Compare
|
The test failure is nothing to do with this patch. |
|
@tananaev / @filippolmt - any thoughts / progress on this ? |
|
Last call. If there's no interest in merging this fix I'll close this PR. |
|
This seems to be approved, but checks are failing. |
|
Check failures do not appear to be related to this change. |
|
Yeah, it might not be related, but we need to fix it before we can merge. |
|
I spent some time on it recently, but it is not trivial. |
Not sure I see why. The broken CI and lack of foreseeable mysql support for it doesn't make this bug fix any more or less valid, relevant or correct. |
|
Nobody is arguing the validity of the issue. |
|
Well, if it's a valid issue and a valid fix, and it hasn't been merged for nearly a year now due to a completely unrelated issue (that has since been fixed by another PR now anyway?) then I can only assume there is no real interest in getting the fix applied. Anyway, patience isn't one of my strong points right now and this has cluttered up my outstanding PR list for too long now. Sorry for the waste of time. |
3 participants
Fixes #32