Skip to content

Adhere to higher refresh rate displays#200

Open
Sotumney wants to merge 1 commit into
tr7zw:mainfrom
Sotumney:highrefresh
Open

Adhere to higher refresh rate displays#200
Sotumney wants to merge 1 commit into
tr7zw:mainfrom
Sotumney:highrefresh

Conversation

@Sotumney

Copy link
Copy Markdown

Removed the arbitrary limit of 60 fps and set it to 240 fps in order to adhere to players on high refresh rate displays and could not stand the 60 fps cap.

I do get that this kinda breaks the spirit of the mod, but will definitely broaden the audience using Exordium!

Removed the arbitrary limit of 60 fps and set it to 240 fps in order to adhere to players on high refresh rate displays and could not stand the 60 fps cap.
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 041c0a34-73b0-40c8-a4e4-661909584a0d

📥 Commits

Reviewing files that changed from the base of the PR and between 15f93fe and b18e01c.

📒 Files selected for processing (1)
  • src/main/java/dev/tr7zw/exordium/config/ExordiumConfigScreen.java

Walkthrough

The maximum allowed value for the FPS integer option in ExordiumConfigScreen#addSettings is increased from 60 to 240. No other logic, defaults, getters, or setters are changed.

Changes

Max FPS Config Upper Bound

Layer / File(s) Summary
Max FPS option upper bound
src/main/java/dev/tr7zw/exordium/config/ExordiumConfigScreen.java
The getIntOption call for the FPS setting changes its max parameter from 60 to 240; default and getter/setter wiring are unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the main change: increasing the fps cap to support high refresh rate displays.
Description check ✅ Passed The description clearly explains the rationale for removing the 60 fps limit and increasing it to 240 fps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@elenawinters

Copy link
Copy Markdown

Why not just pull the monitor refresh rate for the setting if that's even possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants