Skip to content

[Snyk] Security upgrade fastify from 4.28.1 to 5.7.3 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tpsaint wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade fastify from 4.28.1 to 5.7.3 #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5099e76
fix: packages/server/shared/package.json to reduce vulnerabilities
snyk-bot Feb 8, 2026
1cf8ed6
fix: packages/server/shared/package.json to reduce vulnerabilities
snyk-io[bot] Feb 8, 2026
2c3e24e
fix: packages/server/shared/package.json to reduce vulnerabilities
snyk-io[bot] Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/server/shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"async-mutex": "0.4.0",
"@activepieces/pieces-framework": "0.9.0",
"@sinclair/typebox": "0.34.11",
"fastify": "4.28.1",
"fastify": "5.7.3",

@gemini-code-assist gemini-code-assist Bot Feb 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading fastify to a new major version (v5) introduces breaking changes that will break the application, as the required code changes are not included in this PR. This will likely cause the application to fail at startup or during runtime.

Here are some of the issues found in the codebase that need to be addressed:

  1. ajv configuration in packages/server/api/src/app/server.ts: The configuration for ajv is outdated.

    • customOptions is deprecated and must be replaced with opts.
    • The keywords option has been removed. To use custom keywords like discriminator, you need to use ajv.plugins and likely add ajv-keywords as a dependency.

  2. getDefaultJsonParser removed in packages/server/api/src/app/server.ts: The method app.getDefaultJsonParser is used, but it has been removed in fastify v5. You will need to provide your own JSON parser function for the content type parser.

  3. app.hasRoute behavior change in packages/server/api/src/app/app.ts: app.hasRoute is used with request.url. In Fastify v5, the url property for hasRoute must not contain a query string. You should use request.routerPath instead of request.url.

These changes are required for the application to work with fastify v5. I recommend consulting the Fastify v5 migration guide for a complete list of breaking changes before merging this PR.

"@activepieces/import-fresh-webpack": "3.3.0",
"clear-module": "4.1.2",
"axios": "1.8.3"
Expand Down
Loading