fix: build delete filters with PyIceberg expressions - #348
Open
konstantinoscs wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Aug 13, 2026
konstantinoscs
force-pushed
the
feature/tow-2494-iceberg-filter-expressions
branch
from
August 13, 2026 13:52
000543d to
b88edcd
Compare
konstantinoscs
force-pushed
the
feature/tow-2494-iceberg-filter-expressions
branch
2 times, most recently
from
August 13, 2026 17:39
0486414 to
04fcdbf
Compare
konstantinoscs
force-pushed
the
feature/tow-2494-iceberg-filter-expressions
branch
from
August 13, 2026 19:18
04fcdbf to
d808ad0
Compare
konstantinoscs
marked this pull request as ready for review
August 14, 2026 09:09
konstantinoscs
force-pushed
the
feature/tow-2494-iceberg-filter-expressions
branch
from
August 14, 2026 10:42
d808ad0 to
9465063
Compare
konstantinoscs
force-pushed
the
feature/tow-2494-iceberg-filter-expressions
branch
from
August 14, 2026 14:26
9465063 to
3fbbddc
Compare
konstantinoscs
force-pushed
the
feature/tow-2494-iceberg-filter-expressions
branch
from
August 14, 2026 15:34
3fbbddc to
f949272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
This PR replaces Tower's fragile PyArrow-filter string parser with native PyIceberg expressions.
Users can now write filters such as:
SQL-like strings and native PyIceberg expressions remain supported. Old PyArrow expressions now raise a clear migration error before any write credentials are requested.
Why
The previous implementation tried to understand a filter by parsing its rendered text. That could misread column names or values containing words such as
and,or, ornot. Building the expression structurally avoids those errors.S3 Tables and BYO catalog selection and credentials are unchanged.
Testing
Tests cover every comparison operator, logical composition and inversion, nested fields, unusual identifiers and values, and the PyArrow migration error.