ci: test minimum and latest Iceberg dependencies - #346
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
1569945 to
270f29a
Compare
|
@bradhe take another look. I rethought about this. My initial idea was to bound pyiceberg and arrow to make explicit what version we support and what not as unbounded updates can theoretically break the CLI. However I think we can achieve a quite good level of support without bounding the dependencies by triggering a daily job that basically tests that we still support the two pairs of lowest/lowest and latest/latest pyiceberg and arrow. That gives us a quite early signal if there's ever a breaking change upstream |
270f29a to
656491a
Compare
656491a to
5ef2c9f
Compare
| schedule: | ||
| # Detect new stable PyArrow/PyIceberg releases even when no PR is open. | ||
| - cron: "17 6 * * *" |
There was a problem hiding this comment.
Should this just be a separate workflow? Do we need to run the tests on this interval?
There was a problem hiding this comment.
This just runs the tests once a day as well as on every PR.
To me it seems it belongs here. We should run the tests + dependencies compatibility at once? Seems like a reasonable "all things python" coupling.
But If you feel strongly about it, I can move it to another workflow I guess
What this does
Adds a small compatibility matrix for the Tables SDK dependencies:
This PR does not add upper bounds. The existing
>=requirements remain unchanged, so users can install newer stable releases.Why
pyproject.tomlstates which versions are installable; this matrix verifies that the oldest promised versions and the newest available versions actually work. If an upstream release introduces a real incompatibility, CI will show it and we can add a temporary cap based on evidence.The focused suite also keeps the existing managed catalog, S3 Tables, and BYO catalog behavior under test.
Stack
PR 2 of 5. #345 is merged. Next: #347.