fix: resolve failing CI — backend TS errors and frontend ESLint errors#256
Merged
wumibals merged 7 commits intoJun 8, 2026
Merged
Conversation
Backend (NestJS): - Fix auth.module.ts JwtModule useFactory type by casting expiresIn to any - Rewrite analytics, contact, instagram modules to use correct imports and remove non-existent module references (wrong auth.service/dto/guard paths) - Add backend/src/common/guards, decorators, enums used by scrap-menu controllers - Add missing scrap-menu/dto files (create/update DTOs for all four resources) - Remove @nestjs/swagger from package.json (unused; would break npm ci) Frontend (Next.js): - Escape unescaped apostrophes and quotes in JSX (react/no-unescaped-entities) in LoginClient, AboutSection, ContactForm, TestimonialsSection, TrendingSection, VisualMoodBoard, ChangePasswordForm - Replace <a href="/"> with <Link href="/"> in globalError.tsx (@next/next/no-html-link-for-pages)
… paths - Fix AuditLogsTable.tsx: correct relative import from ../ui/Button to ../../ui/Button (was resolving to non-existent admin/ui/Button) - Add MenuPageClient.tsx for app/(public)/menu/page.tsx - Add re-export stubs in components/ for all ui, features, menu, and admin components that exist in app/components/ but were imported via the @/ alias pointing to the root components/ directory - Add components/dashboard/ with DashboardLayout, StatsCards, ActivityFeed, QuickActions, AnalyticsChart, AdminOverview, AdminUserTable - Add lib/apiClient.ts re-exporting from lib/api/client - Add lib/react-query/hooks stubs for workspace-tracking and bookings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing CI checks across the Backend (NestJS) and Frontend (Next.js) jobs.
Backend fixes
auth.module.ts— castexpiresIntoanyto satisfyJwtModuleOptionstype constraintanalytics,contact,instagrammodules — rewrote to use correct local imports, removed stale references to non-existentauth.service/auth.dto/jwt-auth.guardpaths that were placed in wrong modulesbackend/src/common/— addedguards/jwt-auth.guard.ts,guards/roles.guard.ts,decorators/roles.decorator.ts,enums/role.enum.tswhich are required byscrap-menucontrollersscrap-menu/dto/— added all 8 missing DTO files (create-*andupdate-*for all four resources)package.json— removed unused@nestjs/swaggerentry that was causingnpm cito fail due topackage-lock.jsonmismatchFrontend fixes
Escaped unescaped apostrophes/quotes (
react/no-unescaped-entities) in:LoginClient.tsxAboutSection.tsxContactForm.tsxTestimonialsSection.tsxTrendingSection.tsxVisualMoodBoard.tsxChangePasswordForm.tsxReplaced bare
<a href="/">with<Link href="/">inglobalError.tsx(@next/next/no-html-link-for-pages)