Combined changes for release 6.5.6#3626
Merged
Merged
Conversation
This previously used substring search, which is incorrect, although unlikely to be a vulnerability because there are no free-form text fields allowed in this response format.
This ensures we limit the post-decompression size of the body, and not only the compressed size (which is enforced via the Content-Length header at header-processing time).
The lack of this check permitted a read of up to 3 bytes past the end of the string in some cases.
When following a redirect to a different origin (scheme, host, or port), auth-related headers (Authorization and Cookie) should be stripped to avoid exposing them to the new host.
This appears to be a recent libcurl change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.