Skip to content

cli: dto: mark dto deploy command as deprecated#151

Merged
lucas-akira merged 2 commits into
torizon:trixiefrom
GabrielSSAlmeida:TCB-389
Jun 25, 2026
Merged

cli: dto: mark dto deploy command as deprecated#151
lucas-akira merged 2 commits into
torizon:trixiefrom
GabrielSSAlmeida:TCB-389

Conversation

@GabrielSSAlmeida

Copy link
Copy Markdown

The dto deploy command is now marked as deprecated.

Changes:

  • Updated help and description messages to indicate deprecation and point users to the build command
  • Added a runtime log.warning() when the command is invoked, ensuring the deprecation notice is visible even if the user doesn't read the help

Related-to: TCB-389

@jsrc27 jsrc27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments.

Comment thread tcbuilder/cli/dto.py Outdated
Comment thread tcbuilder/cli/dto.py Outdated
@jsrc27
jsrc27 requested review from lucas-akira and rborn-tx June 18, 2026 16:16
Comment thread tcbuilder/cli/dto.py Outdated
Comment thread tcbuilder/cli/dto.py Outdated
Comment thread tcbuilder/cli/dto.py
Comment thread tcbuilder/cli/dto.py Outdated
@rborn-tx

Copy link
Copy Markdown
Collaborator

Hey @GabrielSSAlmeida,

Notice that the commit message title is still above the limit (see the CONTRIBUTING.md guide):

cli: dto: add warning message when it uses the deprecated dto deploy command
<============================== 72 ====================================>

Also, in this repository, we generally capitalize the first word after the scope. Both of your commit messages are using lowercase characters for that first word.

@GabrielSSAlmeida

Copy link
Copy Markdown
Author

Hey @GabrielSSAlmeida,

Notice that the commit message title is still above the limit (see the CONTRIBUTING.md guide):

cli: dto: add warning message when it uses the deprecated dto deploy command
<============================== 72 ====================================>

Also, in this repository, we generally capitalize the first word after the scope. Both of your commit messages are using lowercase characters for that first word.

@rborn-tx I've updated it. Sorry for the inconvenience

Gabriel Almeida added 2 commits June 24, 2026 13:01
This commit adds a warning message to the dto deploy command output
to inform that this command is deprecated and to provide a link
for a best alternative command.

Related-to: TCB-389
Signed-off-by: Gabriel Almeida <gabriel.almeida@toradex.com>
The help and description messages were updated to indicate that now
the dto deploy command is deprecated and should no longer be used.

Related-to: TCB-389
Signed-off-by: Gabriel Almeida <gabriel.almeida@toradex.com>
@GabrielSSAlmeida

Copy link
Copy Markdown
Author

I just did a rebase in the Trixie branch

@lucas-akira lucas-akira left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-akira
lucas-akira merged commit 8299e1e into torizon:trixie Jun 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants