images provision, build: Add support for raw disk images#150
Merged
Conversation
lucas-akira
force-pushed
the
TCB-866
branch
5 times, most recently
from
June 16, 2026 18:06
36ac377 to
e22f541
Compare
jsrc27
reviewed
Jun 17, 2026
jsrc27
left a comment
jsrc27
left a comment
Contributor
There was a problem hiding this comment.
Looks overall good to me. Just left some minor non-critical comments.
lucas-akira
force-pushed
the
TCB-866
branch
4 times, most recently
from
June 18, 2026 16:55
e3db2fc to
53db083
Compare
rborn-tx
reviewed
Jun 19, 2026
rborn-tx
left a comment
rborn-tx
left a comment
Collaborator
There was a problem hiding this comment.
Added a couple of suggestions and comments. Overall the implementation looks good to me.
My main concern is with the general approach we are following where we have different implementations for raw and tezi images inside TCB which is increasing maintenance effort more and more over time.
I wish we unify the two at some point...
Related-to: TCB-866 Signed-off-by: Lucas Akira Morishita <lucas.morishita@toradex.com>
This is based on the work done for the standalone 'images provision' support for raw disk images. Related-to: TCB-866 Signed-off-by: Lucas Akira Morishita <lucas.morishita@toradex.com>
Related-to: TCB-866 Signed-off-by: Lucas Akira Morishita <lucas.morishita@toradex.com>
rborn-tx
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related-to: TCB-866