follow Kubebuilder recommendations in maintenance#184
Merged
Conversation
ushitora-anqou
force-pushed
the
refer-kubebuilder
branch
2 times, most recently
from
2de8a55 to
c0c3a24
Compare
There was a problem hiding this comment.
Pull request overview
Updates the project’s maintenance guidance to align with Kubebuilder’s version compatibility recommendations, and adjusts the module’s declared Go version accordingly.
Changes:
- Refresh
docs/maintenance.mdto direct maintainers to Kubebuilder’s compatibility guidance and sample project versions. - Update the
goversion directive ingo.mod.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| go.mod | Updates the declared Go version for the module. |
| docs/maintenance.md | Updates maintenance instructions to follow Kubebuilder’s compatibility/version guidance and refines upgrade steps text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Kubebuilder uses go 1.25.7, so we should use it, too. cf. https://github.com/kubernetes-sigs/kubebuilder/blob/v4.14.0/testdata/project-v4/go.mod#L3 Note that, if we try to stick to the versions Kubebuilder is using, we should change k8s.io/* libraries' versions from v0.35.4 to v0.35.2. However, there is no strong reason to downgrade the libraries because the current version of pie is stable. Thus, for now, we'll just follow the Go version only. Once we need to support newer versions of Kubernetes we'll follow the Kubebuilder's recommendetaions strictly. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
refer-kubebuilder
branch
from
c0c3a24 to
f4d2895
Compare
ushitora-anqou
changed the title
cupnes
approved these changes
Jun 15, 2026
llamerada-jp
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.