CLOUD-3364 - Parse refresh token to determine expire date#38
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the refresh token handling by parsing the JWT refresh token to extract its actual expiration date instead of using the access token's expiration time as a proxy. The implementation includes a fallback mechanism to maintain backwards compatibility when the refresh token cannot be parsed.
Key Changes:
- Adds JWT parsing capability to extract the refresh token's expiration date from its claims
- Implements a new
determineRefreshTokenExpireDate()function with fallback logic - Adds the
github.com/golang-jwt/jwt/v5dependency for JWT parsing
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/aws_keyhub/keyhub.go | Adds JWT parsing logic to extract refresh token expiration from the token's "exp" claim, with fallback to the previous behavior if parsing fails |
| go.mod | Adds the golang-jwt/jwt/v5 dependency (incorrectly placed in indirect dependencies) |
| go.sum | Adds checksums for the new JWT library dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5c41d39 to
108901a
Compare
erwinvandenbeld
requested changes
Nov 21, 2025
erwinvandenbeld
left a comment
Collaborator
There was a problem hiding this comment.
Graag ticket er bij
mauritsdebruin
approved these changes
Nov 21, 2025
108901a to
57ccc50
Compare
erwinvandenbeld
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.